This repository has been archived by the owner on Dec 9, 2019. It is now read-only.
Unit tests for eosjs-jssig #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 4, 2018 13:50
Might could use a few more tests, but there isn't any error handling to check any expected error behavior against really. And really only a constructor and one method to be tested otherwise. Issue: #44
esheffield
requested review from
tbfleming,
randytorres and
jeffreyssmith2nd
|
Since this has its own tsconfig, maybe name it |
tbfleming
approved these changes
Sep 4, 2018
jeffreyssmith2nd
approved these changes
Sep 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May wish to wait for merge until CI/CD / build changes are merged.
Issue: #44