Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lonLatCenter & lonLatExtent #1181

Merged
merged 6 commits into from
Aug 6, 2024
Merged

Conversation

RobertOrthofer
Copy link
Contributor

@RobertOrthofer RobertOrthofer commented Aug 5, 2024

Implemented changes

This PR adds the read-only-properties EOxMap.lonLatCenter and EOxMap.lonLatExtent, which return the current center and extent in EPSG:4326, no matter the current projection of the view.
Additionally, the new methods transform and transformExtent are now exposed, allowing more flexible transformations between all registered coordinate systems. Basically, these methods are the ol/proj transform and transformExtent functions, with the small adaptation that the destination defaults to EPSG:4326 if not defined.

Screenshots/Videos

Checklist before requesting a review

Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for eoxelements ready!

Name Link
🔨 Latest commit e8942c2
🔍 Latest deploy log https://app.netlify.com/sites/eoxelements/deploys/66b1f2aa8d79d700097b2c6b
😎 Deploy Preview https://deploy-preview-1181--eoxelements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RobertOrthofer RobertOrthofer changed the title Map/feat/transform extent feat: lonLatCenter & lonLatExtent Aug 5, 2024
@RobertOrthofer RobertOrthofer marked this pull request as ready for review August 5, 2024 14:19
Copy link
Collaborator

@silvester-pari silvester-pari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, here it would be nice to have a story showcasing this. ☑️ done

Plus, some description/documentation for the API docs: ☑️ done
image

@silvester-pari
Copy link
Collaborator

I added a very basic story showcasing this, but probably better than nothing.

@RobertOrthofer
Copy link
Contributor Author

Thanks for the story. We should do documentation of all utility functions in the same place, once they are all exported. They probably don't need a map in their story

@silvester-pari silvester-pari linked an issue Aug 6, 2024 that may be closed by this pull request
Copy link
Member

@santilland santilland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial integration tests showed a small issue that was corrected, further tests seem to work as expected, so i think this is good to go!
Thank you @RobertOrthofer for the implementation!

@silvester-pari silvester-pari merged commit 0a154db into main Aug 6, 2024
7 checks passed
@silvester-pari silvester-pari deleted the map/feat/transform-extent branch August 6, 2024 11:55
@github-actions github-actions bot mentioned this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define EPSG:4326 projection for eox-map configuration parameters
3 participants