Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eraser functionality #1

Closed
ramaranjandey opened this issue Aug 23, 2018 · 7 comments
Closed

Eraser functionality #1

ramaranjandey opened this issue Aug 23, 2018 · 7 comments

Comments

@ramaranjandey
Copy link

how to erase like an physical eraser on the canvas

@EP-u-NW
Copy link
Collaborator

EP-u-NW commented Aug 28, 2018

There is no build in function for that, only an undo function.
You can make an eraser yourselfe if you provide an erase button that sets the foreground color to the background color :)

@ramaranjandey
Copy link
Author

ramaranjandey commented Aug 29, 2018 via email

@pkacprzak
Copy link

There is no build in function for that, only an undo function.
You can make an eraser yourselfe if you provide an erase button that sets the foreground color to the background color :)

That's sufficient if one is drawing on a solid background, however, I'd we great to have a proper eraser functionality, so for instance, it works when one is drawing over an image background. Any plans to implement this?

@tmarzeion
Copy link
Collaborator

I've added support for erase mode. Note that it works only on transparent background color.
tmarzeion@d2ce37f
Simply set PainterController's eraseMode property to true.

@EP-u-NW
Copy link
Collaborator

EP-u-NW commented Apr 20, 2020

Hi,
I already peaked at your code. If you would open a PR, Update the LICENSE file to add your name, and briefly explain in the PR how the erease mode works I would merge it :)

@tmarzeion
Copy link
Collaborator

@EPNW
#18
Sorry for not supporting colored background, but I don't have enough time to implement that ATM.

@EP-u-NW
Copy link
Collaborator

EP-u-NW commented Apr 22, 2020

This is finally implemented, seed #18 and 6251475

@EP-u-NW EP-u-NW closed this as completed Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants