issue-740 #741
Merged
issue-740 #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And adds unit test for new behavior.
src/main/java/org/owasp/esapi/logging/slf4j/Slf4JLogBridgeImpl.java
Outdated
Show resolved
Hide resolved
Also adds a test for JavaLogBridgeImplTest for handling nulls.
|
I made the update. I also added a test to the JUL bridge to make sure it doesn't throw an exception on a null event type. |
|
Cool, thanks. |
|
@Jeff-Walker - TBH there hasn't been a lot done since the 2.5.0.0 release on 7/20/2022 and there is a significant time sink in doing the release (typically 2 hrs minimum plus whatever it takes to write up the release notes). Admittedly, the release notes would be comparatively simple this time. I would ideally like to knock out a few more bug fixes before the next release, so I think something around end of Oct / beginning of Nov would be more realistic. |
|
Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds null-safe EventType->Marker translation.
Adds unit test for new behavior.
fixes: #740