Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEON data is hardcoded to use 2018-2019 it should use $DATM_YR_START and $DATM_YR_END #78

Closed
ekluzek opened this issue Apr 30, 2021 · 2 comments · Fixed by #81
Closed

NEON data is hardcoded to use 2018-2019 it should use $DATM_YR_START and $DATM_YR_END #78

ekluzek opened this issue Apr 30, 2021 · 2 comments · Fixed by #81

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Apr 30, 2021

stream_definition_datm.xml in datm/cime_config has the 2018 and 2019 start/end years hardcoded in it, but it should use the $DATM_YR_START and $DATM_YR_END xml variables so that the case case can change them. Right now it doesn't respond to changes in either.

The 2018/2019 defaults could be put in the config_component.xml file, but they would apply to all 1PT forcing cases, but that is likely OK.
This was referenced Apr 30, 2021
Closed
Merged
@ekluzek
Copy link
Collaborator Author

ekluzek commented May 1, 2021

Fixed in P$ #81.

@ekluzek ekluzek closed this as completed May 1, 2021
@ekluzek ekluzek reopened this May 1, 2021
@ekluzek
Copy link
Collaborator Author

ekluzek commented May 1, 2021

I was premature it's not on main-dev yet.

jedwards4b added a commit that referenced this issue May 3, 2021
@jedwards4b
Merge pull request #81 from ekluzek/fix_neon_years
726f4ab 
Set the default DATM_YR_* variables for 1PT streams to 2018 to 2019. For the NEON streams use the $DATM_YR_* settings rather than hardcoded values. This allows the case settings of the DATM_YR_* variables change the datm.streams.xml file.

### Description of changes

### Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #): 
  Fixes #78

Are there dependencies on other component PRs: Yes CTSM
 ESCOMP/CTSM#1278

Are changes expected to change answers? No
 - [x] bit for bit

Any User Interface Changes (namelist or namelist defaults changes)? No
 - [x ] No

Testing performed: 
  Ran SMS_D_Vnuopc.CLM_USRDAT.I1PtClm51Bgc.cheyenne_intel.clm-NEON_NIWO
  which worked and PASSes.

Hashes used for testing:
- [ ] CIME.   cime5.6.43
- [ ] CMEPS v0.10.0
 - [ ] CTSM: ctsm5.1.dev036-31-geb5f2e309 (NEON-compset PR ESCOMP/CTSM#1278)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set default years for 1PT to 2018 to 2019, and use DATM_YR variables for NEON ekluzek/CDEPS
1 participant
@ekluzek