Add check for nans config option #386
Conversation
|
I've introduced a circular dependency - will need to address. |
|
Thanks for adding this flag @jedwards4b ! Given the performance impact documented in #377 (comment) (4.5% slowdown for a typical production case), I would vote for making the default be to not check for NaNs - or maybe to make the default be to check for NaNs in debug cases but not in production cases. My thinking is that, in most cases, NaNs will be detected eventually, so this CMEPS check is more about detecting them as soon as possible... so people can always rerun with the check enabled in these situations. |
mediator/med_methods_mod.F90
Outdated
| #ifndef CESMCOUPLED | ||
| ! For now only CESM uses shr_infnan_isnan - so until other models provide this | ||
| RETURN | ||
| mediator_checkfornans = .false. | ||
| #endif | ||
|
|
||
| if(.not. mediator_checkfornans) return | ||
|
|
There was a problem hiding this comment.
With the change in how you set the config variable, we can remove the CESMCOUPLED ifdef here.
There was a problem hiding this comment.
The reason I haven't done that yet is that the github ext test doesn't include the cdeps library and thus the share code. I am working on updating the github test to include that and then will remove the ifdefs once I have that working. I got pulled into another issue though so it may be a day or two before I can get back to this, for now I'll convert this PR to draft.
There was a problem hiding this comment.
OK, thanks. I was worried I was holding you up by not testing this yet.
|
I have added the cdeps build to the github workflow and removed the CESMCOUPLED ifdefs from med_methods_mod.F90. I think this is ready to merge. |
Description of changes
Add check_for_nans to the nuopc.runconfig
Specific notes
Contributors other than yourself, if any:
CMEPS Issues Fixed: #384
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial) BFB
Any User Interface Changes (namelist or namelist defaults changes)? Add
logical variable check_for_nans modifiable in user_nl_cpl.
Testing performed
Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing
Tested using cesm2_3_alpha13b
PFS.ne30pg3_t061.B1850MOM.cheyenne_intel.allactive-defaultio