Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit PFT optical properties per Majasalmi and Bright (2019) #807

Closed
olyson opened this issue Sep 26, 2019 · 17 comments · Fixed by #990
Closed

Revisit PFT optical properties per Majasalmi and Bright (2019) #807

olyson opened this issue Sep 26, 2019 · 17 comments · Fixed by #990
Assignees
Labels
type: enhancement new capability or improved behavior of existing capability
Milestone

Comments

@olyson
Copy link
Contributor

olyson commented Sep 26, 2019

As discussed in our CLM meeting, we are recommending revisiting the PFT optical property values in CLM and possibly FATES as recommended in a recent paper:

Majasalmi, T. and R. M. Bright, 2019: Evaluation of leaf-level optical properties employed in land surface models. Geoscientific Model Development, 12, 3923-3938.

This paper utilizes various spectral databases to synthesize and harmonize optical property information for PFTs. The paper suggests that CLM optical properties in the visible band fall within the range of measured values. However, there are notable differences between CLM and measured values in the NIR, particularly for conifer trees. Leaf angle values for crops may also be in need of updating.

I'm assigning this to myself:

  1. Based on the paper, update the CLM parameter file
  2. Conduct control and experiment runs to evaluate the impact (regular diagnostics + ILAMB)

Tagging @jkshuman

@olyson olyson added the type: enhancement new capability or improved behavior of existing capability label Sep 26, 2019
@olyson olyson self-assigned this Sep 26, 2019
@ekluzek ekluzek added the tag: next this issue should get some attention in the next week or two label Sep 26, 2019
@billsacks billsacks removed the tag: next this issue should get some attention in the next week or two label Sep 30, 2019
@olyson
Copy link
Contributor Author

olyson commented Oct 16, 2019

I had a 2 degree historical (1989-2014) laying around which can serve as a control.
I ran another simulation with the PFT optical properties changes according to Table S1 of Majasalmi and Bright.
I've attached plots of the control and new pft optical properties (xl: leaf orientation angle, rholvis/rholnir: leaf visible and near-IR reflectance, rhosvis/rhosnir: stem visible and near-IR reflectance, taulvis/taulnir: leaf visible and near-IR transmittance).

plot_PFT_OP.pdf

Diagnostics comparing these runs are here

I've also run ILAMB on these, results are here

We can discuss, but ILAMB doesn't seem to care too much about these new properties. Although scores are slightly better for some variables, particularly most of the relationships.

@dlawrenncar
Copy link
Contributor

Are the changes in albedo similar to what are seen in Majasalmi and Bright, or is that not the right question to as? According to ILAMB Looks like most significant changes (improvements) are seen in tropical regions, which makes sense since it is mainly the tropical PFT properties that are adjusted.

@olyson
Copy link
Contributor Author

olyson commented Oct 18, 2019

They didn't actually run any simulations.

@olyson
Copy link
Contributor Author

olyson commented Mar 18, 2020

Took another look at this because the ILAMB results weren't quite consistent with the changes in the optical properties themselves. Looks like the labels on the ILAMB diagnostics were reversed. Albedo changes in the tropics (albedos are a bit higher) are a bit worse in the new simulation (according to CERES, and to a lesser extent GEWEX.SRB).

@dlawrenncar
Copy link
Contributor

dlawrenncar commented Mar 18, 2020 via email

@olyson
Copy link
Contributor Author

olyson commented Mar 18, 2020

Yes, I agree. For example, I think we (Peter?) kind of tuned the soil albedos for a better match with MODIS albedo. Although this probably shouldn't have that much of an effect in denser canopies.

@ekluzek
Copy link
Contributor

ekluzek commented May 21, 2020

Should this come in as part of the changes for CTSM5.1.0?

@wwieder
Copy link
Contributor

wwieder commented May 21, 2020 via email

@ekluzek
Copy link
Contributor

ekluzek commented May 21, 2020

Yes, do we have a list of PRs that we want on CLM5.1?

CTSM5.1 rather than CLM...

I created a milestone for CTSM5.1.0 and assigned it to the PR's and issues that I thought appropriate. But, @wwieder and others should go through that list as will, so we mark the right things as coming in. If it would be helpful we could create a milestone for CTSM5.2.0 so we could mark the things that are going to come in later.

@wwieder wwieder added this to the ctsm5.1.0 milestone May 21, 2020
@wwieder
Copy link
Contributor

wwieder commented Jun 26, 2020

@dlawrenncar and @ekluzek, should this go into the PPE tag?

@wwieder wwieder added this to To do in Perturbed Parameter Ensemble Branch via automation Jun 26, 2020
@ekluzek
Copy link
Contributor

ekluzek commented Jun 26, 2020

Yes, I think it should. It would just have modified parameters for CTSM5.1 that would change what the default settings for the PPE work would start off with.

@dlawrenncar
Copy link
Contributor

dlawrenncar commented Jun 29, 2020 via email

@wwieder
Copy link
Contributor

wwieder commented Aug 10, 2020

This should go under a 5.1 flag, but not critical for a PPE tag

@wwieder
Copy link
Contributor

wwieder commented Aug 10, 2020

@dlawrenncar suggested that @olyson will be the keeper of the default parameter file for the PPE. @djk2120 should coordinate to make sure where using the right optical parameters.

@ekluzek ekluzek moved this from To do to Done in Perturbed Parameter Ensemble Branch Sep 27, 2020
@olyson
Copy link
Contributor Author

olyson commented Oct 2, 2020

Note that we've decided to also change the optical properties for the newly added miscanthus and switchgrass crop types per Majasalmi and Bright for crop, unless we find a specific reason not to do so.

@wwieder
Copy link
Contributor

wwieder commented Oct 28, 2020

I see this is on the PPE branch, but is it included in CTSM5.1?

@ekluzek
Copy link
Contributor

ekluzek commented Oct 28, 2020

Currently it's in the paramsfile that will be used for the PPE branch. We will bring this in as an update to CTSM5.1 as we bring the PPE changes to master. So it's not in there yet -- but is planned to come in.

@ekluzek ekluzek modified the milestones: ctsm5.1.0, ctsm5.2.0 Nov 12, 2020
@wwieder wwieder modified the milestones: ctsm5.2.0, ctsm5.1.0 Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement new capability or improved behavior of existing capability
Development

Successfully merging a pull request may close this issue.

5 participants