Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge b4bdev 20240307 #2416

Merged
merged 39 commits into from
Mar 13, 2024
Merged

Merge b4bdev 20240307 #2416

merged 39 commits into from
Mar 13, 2024

Conversation

ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Mar 9, 2024

Description of changes

Update of externals to what's expected in cesm2_3_beta17. Some documentation updates including a rebuild
of the documentation and updating how images are handled with git lfs. Improvements to the documentation for
residue removal and tillage for prognostic crops.

#2396
#2385
#2394
#2389

Specific notes

Contributors other than yourself, if any: @samrabin @ekluzek

CTSM Issues Fixed (include github issue #):
Fixes #2351
Fixes #2380
Fixes #2331
Fixes #1910
Fixes #1658
Fixes #2412

Are answers expected to change (and if so in what way)? No bit-for-bit

Any User Interface Changes (namelist or namelist defaults changes)? No

Testing performed, if any: regular testing, build-namelist, python
Testing as expected. With only one test failing compared to the baseline because of missing files in the baseline
FAIL SMS_D_Lm1_Mmpi-serial.CLM_USRDAT.I1PtClm50SpRs.derecho_intel.clm-USUMB_nuopc BASELINE ctsm5.1.dev171: ERROR BFAIL some baseline files were missing

ekluzek and others added 30 commits February 21, 2024 10:56
0f884bfec Merge pull request ESCOMP#205 from jedwards4b/sunset_svn_git_access
82a5edf79 merge in billsacks:svn_testing_no_github
17532c160 Use a local svn repo for testing
9c904341a different method to determine if in tests
539952ebd remove debug print statement
cc5434fa7 fix submodule testing
1d7f28840 remove broken tests
04e94a519 provide a meaningful error message
38bcc0a8c Merge pull request ESCOMP#201 from jedwards4b/partial_match
b4466a5aa remove debug print statement
c3cf3ec35 fix issue with partial branch match

git-subtree-dir: manage_externals
git-subtree-split: 0f884bfec8e43d0c02261de858d6ec3f6d855e51
…o needed to update numpy version for it to work
… are main and develop, with the new externals the testlist wasn't working, it failed trying to setup cases
Merge pull request ESCOMP#2382 from samsrabin/merge-b4bdev-20240222

Brings in 3 PRs from b4b-dev to master:
- Do not crash "make all" even if pylint isn't clean (ESCOMP#2353; Sam Rabin)
- Resolve pylint issues (ESCOMP#2354; Sam Rabin)
- Move FSURDATMODIFYCTSM test to Derecho (ESCOMP#2364; Sam Rabin)
The former is now breaking my ability to build the docs in VSCode. It seems to have no impact on the ability to build the docs using the Docker method.
Should have no effect if it's already initialized, except some extra verbosity.
…D gnu, use one or the other, roughly alturnate between them
…it-lfs

Do "git lfs install" in "make fetch-images", and fix tillage instructions
Update externals to what is expected to be in cesm2_3_beta17 fix some conda issues...
* Correction: 50% of residues are now removed, not 0.
* Removes huge table that can be summarized as "0.7 for biofuel crops and 0 for everything else."
…-50pct

Explain choice of 50% for residue removal
Set initial t_soisno=272K for soils and 274K for urban road
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability bfb bit-for-bit labels Mar 9, 2024
@ekluzek ekluzek self-assigned this Mar 9, 2024
@ekluzek ekluzek requested a review from samsrabin March 9, 2024 00:54
@ekluzek ekluzek merged commit ccbdeb0 into ESCOMP:master Mar 13, 2024
2 checks passed
@ekluzek ekluzek deleted the merge-b4bdev-20240307 branch March 13, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit enhancement new capability or improved behavior of existing capability
Projects
Status: Done
2 participants