Fix subset_data (cth and cbh not iterable) #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FATES default allometry parameter file update
This updates the default FATES parameter file which includes a number
of changes:
- Default global tree pft allometry update
- New allometric mode options
- New scaling coefficients for alternative leaf maintenance respiration
- New switch to control the use of host land model day length scaling factor
This also incorporates some testing additions and clean up, including:
- Removes cheyenne expected failure tests that have been converted to derecho
- Adds a 5x5_amazon test to aux_clm and the expected failures list
- Temporarilry converts a fates 5x5_amazon test to f10 test
- Adds namelist check and corresponding unit test to make sure fates hydro
and fates satellite phenology mode can not be used together
The FATES externals tag is also updated which includes a number of bug fixes
and the addition of new history output.
Merge master into b4b-dev 2024-05-02
Fix long names for RH2M_R, AZSUN, and update nofates and fates history variable lists in User's Guide
samsrabin
added
the
next
slevis-lmwg
approved these changes
May 6, 2024
There was a problem hiding this comment.
@samsrabin thank you for coming up with this elegant solution and for including unit tests for it. I do not see issues or have concerns if you have confirmed that it works.
|
Thanks for getting this in @samsrabin. when I suggested the next b4bdev tag I wasn't meaning this one, but thanks for busting this out! |
samsrabin
removed
the
next
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Ensures that
cthandcbhare iterable before passing tozip(). Without this, most calls ofsubset_data(at least for single-point cases) will fail.Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed:
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? Not needed
Testing performed, if any:
ensure_iterable().