-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix subset_data (cth and cbh not iterable) #2528
Conversation
FATES default allometry parameter file update This updates the default FATES parameter file which includes a number of changes: - Default global tree pft allometry update - New allometric mode options - New scaling coefficients for alternative leaf maintenance respiration - New switch to control the use of host land model day length scaling factor This also incorporates some testing additions and clean up, including: - Removes cheyenne expected failure tests that have been converted to derecho - Adds a 5x5_amazon test to aux_clm and the expected failures list - Temporarilry converts a fates 5x5_amazon test to f10 test - Adds namelist check and corresponding unit test to make sure fates hydro and fates satellite phenology mode can not be used together The FATES externals tag is also updated which includes a number of bug fixes and the addition of new history output.
Merge master into b4b-dev 2024-05-02
Fix long names for RH2M_R, AZSUN, and update nofates and fates history variable lists in User's Guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samsrabin thank you for coming up with this elegant solution and for including unit tests for it. I do not see issues or have concerns if you have confirmed that it works.
Thanks for getting this in @samsrabin. when I suggested the next b4bdev tag I wasn't meaning this one, but thanks for busting this out! |
Description of changes
Ensures that
cth
andcbh
are iterable before passing tozip()
. Without this, most calls ofsubset_data
(at least for single-point cases) will fail.Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed:
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? Not needed
Testing performed, if any:
ensure_iterable()
.