Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 72 provenance #134

Merged
merged 11 commits into from Jan 27, 2021
Merged

Feature 72 provenance #134

merged 11 commits into from Jan 27, 2021

Conversation

mbjones
Copy link
Collaborator

@mbjones mbjones commented Jan 22, 2021

PR for provenance additions as discussed in #72. This adds guidelines for describing derived datasets, previous versions, and software workflows using mainly predicates from the PROV and ProvONE vocabularies.

I cleaned up editing for this branch, brought it up to date with develop, and added an example to full.jsonld for guidance. No substantive changes were made since we last discussed this on one of our calls and agreed to the approach. I checked the resulting full.jsonld in the JSON-LD playground and all seems to resolve.

@mbjones mbjones added this to the v1.2 milestone Jan 22, 2021
@mbjones mbjones self-assigned this Jan 22, 2021
@mbjones mbjones linked an issue Jan 22, 2021 that may be closed by this pull request
Copy link
Member

@ashepherd ashepherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @mdjones. Just suggested we might use @id so that it links to the resource and not the textual URL? thoughts?

@@ -210,5 +212,13 @@
}
]
}
]
],
"prov:wasDerivedFrom": "https://doi.org/10.xxxx/Dataset-1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want to use @id to link to resources? thoughts?

"prov:wasDerivedFrom": { "@id": "https://doi.org/10.xxxx/Dataset-1"},
"schema:isBasedOn": { "@id": "https://doi.org/10.xxxx/Dataset-1"},

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point. I'll make the "@id" changes.

"@id": "https://doi.org/10.xxxx/Dataset-2",
"@type": "Dataset",
"name": "Removal of organic carbon by natural bacterioplankton communities as a function of pCO2 from laboratory experiments between 2012 and 2016",
<strong>"prov:wasDerivedFrom": "https://doi.org/10.xxxx/Dataset-1"</strong>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use @id?

"@id": "https://doi.org/10.xxxx/Dataset-2",
"@type": "Dataset",
"name": "Removal of organic carbon by natural bacterioplankton communities as a function of pCO2 from laboratory experiments between 2012 and 2016",
"prov:wasDerivedFrom": "https://doi.org/10.xxxx/Dataset-1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use @id?

@mbjones
Copy link
Collaborator Author

mbjones commented Jan 27, 2021

I made the @id changes as you requested @ashepherd, and I am going to merge into develop now. Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intention of adding provenance of DOIs with isBasedOn?
2 participants