Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 74 rdf type vs schema additional type #95

Merged
merged 6 commits into from Mar 27, 2020

Conversation

ashepherd
Copy link
Member

@ashepherd ashepherd commented Mar 3, 2020

Completes issue #74

Most of the ADR had already been adopted.

  • updated example JSON-LD for use of schema:additionalType; moved to @type
  • updated the ADR 74-schemaorg-additionalType-vs-RDF-typing to 'Adopted'

@ashepherd ashepherd added this to the v1.1 milestone Mar 3, 2020
@ashepherd ashepherd changed the base branch from master to develop March 3, 2020 13:40
@mbjones mbjones self-requested a review March 3, 2020 18:31
Copy link
Collaborator

@mbjones mbjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good. The one thing I noticed is that we should probably update the text in the CONVENTIONS.md in the section Typing to External Vocabularies to reflect the change to using @type. Most of the text in that section can probably be replaced with a description of how to use external types. I would recommend it include an overview of what happens in the Google Structured Data Testing Tool and a good example or two.

@ashepherd
Copy link
Member Author

Great! thanks @mbjones. I've updated CONVENTIONS.md

Copy link
Member Author

@ashepherd ashepherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mbjones (mac keyboard issue has been a pain). i can't approve my own pull request if someone else here can do that, that'd be great.

Copy link
Collaborator

@mbjones mbjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adam, the use of @typeguidelines look good to me. I merged in recent changes from develop, and then fixed some typos and wording in the feature branch. So, I think it is ready to be merged.

@ashepherd ashepherd merged commit 0d71e74 into develop Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants