Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some new grids for mizuRoute with Lakes #67

Closed
ekluzek opened this issue Nov 10, 2022 · 2 comments · Fixed by #75
Closed

Add some new grids for mizuRoute with Lakes #67

ekluzek opened this issue Nov 10, 2022 · 2 comments · Fixed by #75
Assignees
@ekluzek
Labels
enhancement New feature or request question Further information is requested

Comments

@ekluzek
Copy link
Contributor

ekluzek commented Nov 10, 2022

We need to add some new grids for mizuRoute that will have lakes in them. The grid is different when lakes are explicitly modeled versus grids that don't have lakes.

The component grids for HDMAmz will also need a lake version.
@ekluzek ekluzek added enhancement New feature or request question Further information is requested labels Nov 10, 2022
@ekluzek ekluzek self-assigned this Nov 10, 2022
@ekluzek
Copy link
Contributor Author

ekluzek commented Nov 10, 2022

We want to suggest:

HDMA-lake-mz

as the name. I think dashes might be allowed in grid names, although we don't currently use them.

The grid aliases we envision needing are:

hcru_hcru_mt13_rHDMA-lake
f09_f09_mg17_rHDMA-lake
f19_f19_mg17_rHDMA-lake

I like suggesting lowercase for lake since it isn't an acronym but HDMA is.

@ekluzek
Copy link
Contributor Author

ekluzek commented Dec 6, 2022

Based on discussion in #70 we want to propose them to be:

hcru_hcru_rHDMAlk_mt13
f09_f09_rHDMAlk_mg17
f19_f19_rHDMAlk_mg17

@ekluzek ekluzek mentioned this issue Dec 13, 2022
Merged
fischer-ncar added a commit that referenced this issue Dec 17, 2022
@fischer-ncar
Merge pull request #75 from ekluzek/mizuroutelakegrids
e0cc73e 
This adds some new grids for mizuRoute lake HDMA-lake option, and also changes the mizuRoute grid aliases to the convention discussed previously.

Fixes #67
Uses the convention as addressed in #70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ekluzek ekluzek

Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MizuRoute lake grids ekluzek/ccs_config_cesm
1 participant
@ekluzek