Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back changes from PR4497 #4540

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Add back changes from PR4497 #4540

merged 3 commits into from
Feb 2, 2024

Conversation

fischer-ncar
Copy link
Contributor

Put back in changes for PR #4497.

From PR #4497.
The update is needed for use with GEOS-Chem chemistry so that run-time configuration files can be copied to the case directory upon case setup. This PR should be merged along with CAM PR ESCOMP/CAM#484 at the same time.

Test suite:
Test baseline:
Test namelist changes:
Test status: [bit for bit, roundoff, climate changing]

Fixes [CIME Github issue #]

User interface changes?:

Update gh-pages html (Y/N)?:

@lizziel
Copy link
Contributor

lizziel commented Feb 2, 2024

This update will be needed soon as the GEOS-Chem PR is in the final test phase. See ESCOMP/CAM#484.
@fischer-ncar, @fvitt, @jedwards4b

@fvitt
Copy link
Contributor

fvitt commented Feb 2, 2024

Will the copy happen only for GEOS-Chem compsets or all compsets?
Why can't cam copy files over? Why do we need cime to do this?

@jedwards4b
Copy link
Contributor

@fvitt cime is invoking a new script in the cam tree called cam_case_setup.py - if you can do this without a change in cime I think that would be preferable.

@gold2718
Copy link

gold2718 commented Feb 2, 2024

Why can't cam copy files over? Why do we need cime to do this?

I think the issue is when will CAM have a chance to copy these files and is it soon enough? These files are similar in purpose and timing to the user_nl_xxx files such as user_nl_cam. In the CIME world, users are supposed to be able to edit these files before any CAM script (buildlib or buildnml) has been run which is why CIME is installing the user_nl_xxx files and not each individual component. This is the same reason that the same script installs the cism_template file.

@gold2718
Copy link

gold2718 commented Feb 2, 2024

Will the copy happen only for GEOS-Chem compsets or all compsets?

If you look at cam.case_setup.py in the CAM PR, you can see that it only copies files if -chem geoschem is specified.

@lizziel
Copy link
Contributor

lizziel commented Feb 2, 2024

The original implementation had the copy done by CAM within buildnml. See https://github.com/CESM-GC/CAM/blob/e2f974419dcb08ef7cbb49b2d4ebb757f3128dc9/cime_config/buildnml#L179-L199. The CIME update seems more elegant because it allows invoking component-specific instructions for case setup. Perhaps it could be updated to not require a case setup script in CAM.

@fvitt
Copy link
Contributor

fvitt commented Feb 2, 2024

OK. Thanks for the explanations.

@jedwards4b
Copy link
Contributor

@fischer-ncar I think that if you merge cime master into this branch and push a new commit the unit-testing will pass, e3sm is currently a known failure.

@fischer-ncar fischer-ncar marked this pull request as ready for review February 2, 2024 18:19
@jedwards4b jedwards4b merged commit 475beb2 into master Feb 2, 2024
5 of 6 checks passed
@jedwards4b jedwards4b deleted the fischer/pr4497_redo branch February 2, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants