New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly use masked arrays after unstructured_nearest
regridding
#1414
Conversation
unstructured_nearest
regridding
Codecov Report
@@ Coverage Diff @@
## main #1414 +/- ##
=======================================
Coverage 88.85% 88.86%
=======================================
Files 196 196
Lines 9959 9965 +6
=======================================
+ Hits 8849 8855 +6
Misses 1110 1110
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! when iris will have fixed this it'd be good to remove the condition but leave the test - I'd argue an issue about this on GH scitools-iris would be good to have π
I found an issue with this, please do not merge yet π¬ |
you merge at will, man, am off on baby Jesus holidays π π |
Cheers, happy holidays!! π π |
Description
Right now,
unstructured_nearest
regridding does not return masked arrays. This PR fixes this.Closes #1413
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the π Technical or π§ͺ Scientific review.
To help with the number pull requests: