Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly use masked arrays after unstructured_nearest regridding #1414

Merged
merged 5 commits into from Dec 17, 2021

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Dec 14, 2021

Description

Right now, unstructured_nearest regridding does not return masked arrays. This PR fixes this.

Closes #1413

Link to documentation:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.


To help with the number pull requests:

@schlunma schlunma added bug Something isn't working preprocessor Related to the preprocessor labels Dec 14, 2021
@schlunma schlunma added this to the v2.5.0 milestone Dec 14, 2021
@schlunma schlunma self-assigned this Dec 14, 2021
@schlunma schlunma requested a review from zklaus December 14, 2021 15:53
@schlunma schlunma changed the title Correctly use masked arrays after unstructered nearest regridding Correctly use masked arrays after unstructured_nearest regridding Dec 14, 2021
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #1414 (9c283ed) into main (5131ffc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1414   +/-   ##
=======================================
  Coverage   88.85%   88.86%           
=======================================
  Files         196      196           
  Lines        9959     9965    +6     
=======================================
+ Hits         8849     8855    +6     
  Misses       1110     1110           
Impacted Files Coverage Ξ”
esmvalcore/preprocessor/_regrid.py 96.73% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 5131ffc...9c283ed. Read the comment docs.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! when iris will have fixed this it'd be good to remove the condition but leave the test - I'd argue an issue about this on GH scitools-iris would be good to have πŸ‘

@schlunma
Copy link
Contributor Author

I found an issue with this, please do not merge yet 😬

@valeriupredoi
Copy link
Contributor

you merge at will, man, am off on baby Jesus holidays πŸŽ„ πŸŽ…

@schlunma
Copy link
Contributor Author

schlunma commented Dec 16, 2021

Cheers, happy holidays!! πŸŽ… πŸŽ„

@schlunma schlunma merged commit b070a4b into main Dec 17, 2021
@schlunma schlunma deleted the fix_unstructured_nearest_regrid branch December 17, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working preprocessor Related to the preprocessor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unstructured_nearest regridding does not return masked arrays
2 participants