Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add derivation of sea ice extent #1695

Merged
merged 18 commits into from Nov 3, 2022
Merged

Add derivation of sea ice extent #1695

merged 18 commits into from Nov 3, 2022

Conversation

sloosvel
Copy link
Contributor

@sloosvel sloosvel commented Aug 9, 2022

Description

This PR allows to compute the sea ice extent as a derived variable in order to reduce the amount of saved data during the preprocessing
Closes #1693

Link to documentation:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.


To help with the number pull requests:

@sloosvel sloosvel added the variable derivation Related to variable derivation functions label Aug 9, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #1695 (439759f) into main (3149d07) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1695      +/-   ##
==========================================
+ Coverage   91.16%   91.18%   +0.02%     
==========================================
  Files         202      203       +1     
  Lines       10882    10908      +26     
==========================================
+ Hits         9921     9947      +26     
  Misses        961      961              
Impacted Files Coverage Ξ”
esmvalcore/preprocessor/_derive/siextent.py 100.00% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dhohn dhohn mentioned this pull request Oct 7, 2022
@sloosvel sloosvel marked this pull request as ready for review October 25, 2022 15:18
@sloosvel sloosvel requested a review from dhohn October 25, 2022 15:19
@sloosvel
Copy link
Contributor Author

Hi @dhohn , this is now ready to be reviewed. Do you think you could test the changes?

Copy link
Contributor

@dhohn dhohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ive made a couple plots which look correct. I also tried a model (ACCESS) that provides both siconc and siconca, which also works.

@sloosvel
Copy link
Contributor Author

sloosvel commented Nov 2, 2022

Thanks @dhohn !

@ESMValGroup/technical-lead-development-team anyone with time to merge? I can do it if there are no further comments, but since we agreed ond having the merger be different than the reviewer I thought I would ask.

@sloosvel sloosvel merged commit 3666bfa into main Nov 3, 2022
@sloosvel sloosvel deleted the dev_siextent branch November 3, 2022 08:06
@bouweandela
Copy link
Member

anyone with time to merge?

I would have been happy to do it. Maybe you could wait a bit longer next time, to give people an opportunity to respond to your question?

@sloosvel
Copy link
Contributor Author

sloosvel commented Nov 3, 2022

ups, will do! sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
variable derivation Related to variable derivation functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sea Ice Extent as a derived variable
3 participants