Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.7.1 bugfix release] Finalize v2.7.1 bugfix: add changelog for v2.7.1 bugfix release #1858

Merged
merged 7 commits into from Dec 9, 2022

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Dec 8, 2022

Add Changelog for v2.7.1 (V's own creation) and semantic versioning from PR #1854

Added changelog

@bouweandela
Copy link
Member

Sorry, I acccidentally merged main into this branch because I clicked the update button and the target branch is set to main instead of v2.7.x. Is that on purpose?

It would be nice to separate updating the version numbering from adding the changelog.

@valeriupredoi valeriupredoi changed the base branch from main to v2.7.x December 9, 2022 11:56
@valeriupredoi
Copy link
Contributor Author

It would be nice to separate updating the version numbering from adding the changelog

OK, the PR torture continues then 😆

@valeriupredoi valeriupredoi changed the title [v2.7.1 bugfix release] Finalize v2.7.1 bugfix: add changelog and support for semantic versioning in pyproject.toml [v2.7.1 bugfix release] Finalize v2.7.1 bugfix: add changelog for v2.7.1 bugfix release Dec 9, 2022
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #1858 (f4bde15) into v2.7.x (578fb61) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           v2.7.x    #1858   +/-   ##
=======================================
  Coverage   91.02%   91.02%           
=======================================
  Files         207      207           
  Lines       11216    11216           
=======================================
  Hits        10209    10209           
  Misses       1007     1007           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bouweandela
Copy link
Member

Could you also add the changes from #1864 to the log?

@valeriupredoi
Copy link
Contributor Author

Yis, was just about to holler at you not to merge this just yet coz I need to add that - but will add it as #1838 rather than #1864 👍

doc/changelog.rst Outdated Show resolved Hide resolved
@bouweandela bouweandela merged commit 89ee7f4 into v2.7.x Dec 9, 2022
@bouweandela bouweandela deleted the finalize_271bugfix branch December 9, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants