New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make time-related fixes work with time dimensions time1
, time2
, time3
#1971
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1971 +/- ##
=======================================
Coverage 92.79% 92.79%
=======================================
Files 236 236
Lines 12437 12440 +3
=======================================
+ Hits 11541 11544 +3
Misses 896 896
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me π₯³
I did not try it on any real data though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, cheers, Manu πΊ
Description
CMIP6 provides multiple time dimensions, e.g.,
time
,time1
, etc. They all have the common standard nametime
.Currently, we are using the dimension name (
time
,time1
, ...) to identify coordinates in fixes. This PR introduces a convenience methodVariableInfo.has_coord_with_standard_name
to identify coordinates through theirstandard_name
.Closes #1969
Link to documentation: https://esmvaltool--1971.org.readthedocs.build/projects/ESMValCore/en/1971/api/esmvalcore.cmor.html?highlight=has_dimension#esmvalcore.cmor.table.VariableInfo.has_coord_with_standard_name
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the π Technical or π§ͺ Scientific review.
To help with the number pull requests: