Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix areacello in BCC-CSM2-MR #1993

Merged
merged 3 commits into from Mar 31, 2023
Merged

Fix areacello in BCC-CSM2-MR #1993

merged 3 commits into from Mar 31, 2023

Conversation

remi-kazeroni
Copy link
Contributor

@remi-kazeroni remi-kazeroni commented Mar 30, 2023

Description

This PRs applies the OceanFixGrid to the areacello of the BCC-CSM2-MR model. That is needed for ESMValGroup/ESMValTool#3021.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@remi-kazeroni remi-kazeroni added the fix for dataset Related to dataset-specific fix files label Mar 30, 2023
@remi-kazeroni remi-kazeroni added this to the v2.9.0 milestone Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #1993 (ca3b31a) into main (c5d23e2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1993   +/-   ##
=======================================
  Coverage   92.79%   92.79%           
=======================================
  Files         236      236           
  Lines       12437    12438    +1     
=======================================
+ Hits        11541    11542    +1     
  Misses        896      896           
Impacted Files Coverage Δ
esmvalcore/cmor/_fixes/cmip6/bcc_csm2_mr.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@remi-kazeroni remi-kazeroni marked this pull request as ready for review March 30, 2023 14:47
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @remi-kazeroni!

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it do to me too 🍺

@valeriupredoi valeriupredoi merged commit 72b4169 into main Mar 31, 2023
4 checks passed
@valeriupredoi valeriupredoi deleted the fix_bcc_csm2_mr_areacello branch March 31, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix for dataset Related to dataset-specific fix files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants