Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to always create cache directory when using ICON grid files #2030

Merged
merged 2 commits into from May 19, 2023

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented May 16, 2023

Description

Currently, the ICON on-the-fly CMORizer might fail if a user does not already have the $HOME/.esmvaltool/cache directory. The relevant mkdir is called AFTER the first usage of this cache directory. This PR fixes that.

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the bug Something isn't working label May 16, 2023
@schlunma schlunma added this to the v2.9.0 milestone May 16, 2023
@schlunma schlunma self-assigned this May 16, 2023
@schlunma schlunma marked this pull request as ready for review May 16, 2023 10:40
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #2030 (69f4efd) into main (f192e40) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2030   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files         236      236           
  Lines       12464    12464           
=======================================
  Hits        11565    11565           
  Misses        899      899           
Impacted Files Coverage Δ
esmvalcore/cmor/_fixes/icon/_base_fixes.py 100.00% <100.00%> (ø)

Copy link
Contributor

@sloosvel sloosvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not very familiar with the ICON cmorizer, but the changes look sensible, thanks!

@bouweandela bouweandela merged commit 9fcb007 into main May 19, 2023
4 checks passed
@bouweandela bouweandela deleted the fix_icon_cache_dir_creation branch May 19, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants