Fixed bug in ICON CMORizer that lead to shifted time coordinates #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2038 +/- ##
==========================================
+ Coverage 92.94% 92.97% +0.03%
==========================================
Files 235 235
Lines 12550 12604 +54
==========================================
+ Hits 11664 11718 +54
Misses 886 886
|
remi-kazeroni
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Thanks for addressing this issue @schlunma! Code looks good to me and the documentation on this topic is clear. This PR makes it easier to work with ICON output. Apart from a tiny suggestion, this is good to be merged.
|
@schlunma pls address the optional review comment from Remi, fix the conflict, then ping me here and I shall merge 🍺 |
Co-authored-by: Rémi Kazeroni <remi.kazeroni@dlr.de>
|
ping @valeriupredoi 🍻 |
valeriupredoi
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default, ICON reports aggregated data at the end of the output interval, e.g., the 2020 January mean is reported as 1 February 2020 (
20200201). Since the raw output does not contain time bounds, this is impossible to tell from the data alone. This affects all other time frequencies (e.g., daily data is shifted by half a day, 6hr data by 3 hours, etc.).This PR fixes this by shifting all time points back by 1/2 of the output interval. This feature is enabled by default, but can be disabled in the recipe/extra facets by
shift_time: false.I tested this successfully on real monthly, daily, 3hourly and hourly ICON data. After this fix, the ICON top-of-the-atmosphere incoming solar radiation is in sync with observations:
Closes #2024
Closes #2017
Link to documentation: https://esmvaltool--2038.org.readthedocs.build/projects/ESMValCore/en/2038/quickstart/find_data.html#icon
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: