New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated configuration options #2056
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2056 +/- ##
==========================================
+ Coverage 92.79% 92.87% +0.07%
==========================================
Files 236 234 -2
Lines 12484 12441 -43
==========================================
- Hits 11585 11554 -31
+ Misses 899 887 -12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks bud, these slated to be removed in 2.9 right?
@schlunma maybe you got a couple seconds have a last look at this then merge, pls. bud 馃嵑 |
Thanks @bouweandela for taking care of this! It seems that one of these functions is still used in ESMValTool: https://github.com/ESMValGroup/ESMValTool/blob/main/tests/system/data_simulator.py#L10 Could you either open an issue or PR to address this, please? Thanks!! |
done! Am on a roll today 馃榿 ESMValGroup/ESMValTool#3195 |
|
Bouwe needs to read comments more often and I need to check for existing issues 馃ぃ |
Description
Remove various deprecated configuration modules and methods:
esmvalcore.experimental.config
-> to upgrade, import the module fromesmvalcore.config
esmvalcore._config
-> to upgrade, useesmvalcore.config
insteadesmvalcore.config.Session.to_config_user
andesmvalcore.config.from_config_user
-> to upgrade, useesmvalcore.config.Session
to access the configuration values instead of a separatedict
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 馃洜 Technical or 馃И Scientific review.
To help with the number pull requests: