Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated configuration options #2056

Merged
merged 1 commit into from May 26, 2023

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented May 23, 2023

Description

Remove various deprecated configuration modules and methods:

  • esmvalcore.experimental.config -> to upgrade, import the module from esmvalcore.config
  • esmvalcore._config -> to upgrade, use esmvalcore.config instead
  • esmvalcore.config.Session.to_config_user and esmvalcore.config.from_config_user -> to upgrade, use esmvalcore.config.Session to access the configuration values instead of a separate dict

Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 馃洜 Technical or 馃И Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #2056 (d96be5a) into main (64f7c0f) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2056      +/-   ##
==========================================
+ Coverage   92.79%   92.87%   +0.07%     
==========================================
  Files         236      234       -2     
  Lines       12484    12441      -43     
==========================================
- Hits        11585    11554      -31     
+ Misses        899      887      -12     
Impacted Files Coverage 螖
esmvalcore/config/_config_object.py 94.95% <酶> (+7.37%) 猬嗭笍

@bouweandela bouweandela marked this pull request as ready for review May 23, 2023 10:57
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks bud, these slated to be removed in 2.9 right?

@valeriupredoi
Copy link
Contributor

@schlunma maybe you got a couple seconds have a last look at this then merge, pls. bud 馃嵑

@schlunma
Copy link
Contributor

Thanks @bouweandela for taking care of this!

It seems that one of these functions is still used in ESMValTool: https://github.com/ESMValGroup/ESMValTool/blob/main/tests/system/data_simulator.py#L10

Could you either open an issue or PR to address this, please? Thanks!!

@schlunma schlunma merged commit 2e7e384 into main May 26, 2023
4 checks passed
@schlunma schlunma deleted the remove-deprecated-config-options branch May 26, 2023 13:28
@valeriupredoi
Copy link
Contributor

done! Am on a roll today 馃榿 ESMValGroup/ESMValTool#3195

@bouweandela
Copy link
Member Author

Could you either open an issue or PR to address this, please? Thanks!!

See ESMValGroup/ESMValTool#3109

@valeriupredoi
Copy link
Contributor

Bouwe needs to read comments more often and I need to check for existing issues 馃ぃ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants