Show ESMValTool logo on PyPI webpage #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2065 +/- ##
=======================================
Coverage 92.79% 92.79%
=======================================
Files 236 236
Lines 12484 12484
=======================================
Hits 11585 11585
Misses 899 899 |
zklaus
approved these changes
May 25, 2023
|
@valeriupredoi Could you update the title to something that reads well in the changelog please? |
valeriupredoi
changed the title
|
@bouweandela better now? I love the word "poof" 馃槵 |
|
How about something like 'Show ESMValTool logo on PyPI webpage'? 'RAW path' doesn't mean much to most of the people reading the log. |
valeriupredoi
changed the title
valeriupredoi
changed the title
|
reason prevailed, but do check out the second to last title 馃ぃ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sister PR to Tool's ESMValGroup/ESMValTool#3185 - our nice and happy logo has disappeared off the PyPI pkg page, most probably since we don't link it from the RAW file on the README
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 馃洜 Technical or 馃И Scientific review.
To help with the number pull requests: