Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add python 3.11 to github actions tests installing deployed packages (conda and PyPI) #2083

Merged
merged 2 commits into from Jun 6, 2023

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jun 5, 2023

Description

Now that we have esmvalcore=2.8.1 out and supporting python=3.11 we need to add py311 to GA tests running installs from deployed packages. @bouweandela pls include this in the bugfixes category, so we can have it for 2.9.0rc1 or 2.9.0stable, depending what you choose do, bud 馃嵑

Closes #2064


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 馃洜 Technical or 馃И Scientific review.


To help with the number pull requests:

@valeriupredoi valeriupredoi added this to the v2.9.0 milestone Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #2083 (9a12ee1) into main (bc5a4ac) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2083   +/-   ##
=======================================
  Coverage   93.06%   93.06%           
=======================================
  Files         237      237           
  Lines       12743    12743           
=======================================
  Hits        11859    11859           
  Misses        884      884           

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you clean it up?

.github/workflows/install-from-conda.yml Outdated Show resolved Hide resolved
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
@valeriupredoi
Copy link
Contributor Author

cheers, bud, was waiting on the OSX tests that were queued interminably 馃榿

@bouweandela bouweandela merged commit 3067ce6 into main Jun 6, 2023
4 checks passed
@bouweandela bouweandela deleted the GA_add_py11_conda-pypi_install branch June 6, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Github Actions] PyPI and conda tests need be done with Python=3.11 too after Core package stable deployment
2 participants