remove with_mypy or with-mypy extension/optional tool for prospector

[valeriupredoi]

Description

There is an issue with prospector=1.10.2 at the moment and installing it with with_mypy makes it not work at all, so I am removing this extra tool for now, so we have some functionality out of it, rather than a complete shutdown;

Nevermind, prospectpr=1.10.2 needs with-mypy instead of with_mypy due to poetry changing version, and @carlio (the prospector main dev) tells me this may change in the future again, depending how poetry wakes up in the morning (what version it is one)

@bouweandela suggested we remove the extra tool option altogether since we run the mypy tests separately anyway 👍

See landscapeio/prospector#624

---

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🛠 This pull request has a descriptive title and labels
• 🛠 Any changed dependencies have been added or removed correctly
• 🛠 All checks below this pull request were successful

---

To help with the number pull requests:

• 🙏 We kindly ask you to review two other open pull requests in this repository

[codecov]

Codecov Report

Merging #2108 (99d4aa8) into main (cf3824e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2108   +/-   ##
=======================================
  Coverage   93.08%   93.08%           
=======================================
  Files         237      237           
  Lines       12793    12793           
=======================================
  Hits        11909    11909           
  Misses        884      884           

[bouweandela]

We can just drop the with_mypy/with-mypy extra because we're installing mypy separately already.

[valeriupredoi]

aha! Let me do that now - even better! 🍺

[bouweandela]

@bouweandela suggested we remove the extra tool option altogether since we run the mypy tests separately anyway +1

What I actually meant is that we're installing mypy as a separate tool as well, so there is no need to pull it in through the prospector with_mypy extra. Because it is installed, it works fine with prospector too.

[valeriupredoi]

@bouweandela suggested we remove the extra tool option altogether since we run the mypy tests separately anyway +1

What I actually meant is that we're installing mypy as a separate tool as well, so there is no need to pull it in through the prospector with_mypy extra. Because it is installed, it works fine with prospector too.

indeed - mypy is a core dep for us here - may want to deouble check in Tool though

[valeriupredoi]

thanks bud 🍺