Several minor fixes needed for marine BGC data.

[ledm]

Here are some fairly straightforward fixes for various CMIP6 models. Several of these models are simply not receiving the "standard" OceanFixGrid fixes that they need. Could we instead just apply that to every model - or is that a bad idea?

PR is a draft as it's a work in progress.

[valeriupredoi]

cheers @ledm - could you pls fix the flake8 issues (line too long etc) 🍺

[chrisbillowsMO]

Hi @ledm - following on from the community call earlier, would you have time to complete this PR by the end of next week? If not would you be happy to move it to the next milestone v2.12.0 please?

[valeriupredoi]

@ledm am giving you a hand here, so it's merged this m2.11 rather than postpone it yet again 👍

[valeriupredoi]

OK flake8 issues fixed, so we have green tests now, please proceed with work, and let me know when you'd want a review, or please change the milestone to M2.12 and see about it afterwards - up to you @ledm 🍺

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.38%. Comparing base (9912921) to head (0d88785).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2110   +/-   ##
=======================================
  Coverage   94.38%   94.38%           
=======================================
  Files         246      246           
  Lines       13739    13743    +4     
=======================================
+ Hits        12967    12971    +4     
  Misses        772      772           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[valeriupredoi]

many thanks @ledm LGTM 🍺 @schlunma would you be able to give this one a lookover when you got a minute, plss bud? We can then merge and make the 2.11 cut ✂️

[schlunma]

Would be great if you can add some (minimal) tests for this, e.g.,

ESMValCore/tests/integration/cmor/_fixes/cmip6/test_bcc_esm1.py

Lines 61 to 69 in 9912921

	def test_get_sos_fix():
	"""Test getting of fix."""
	fix = Fix.get_fixes('CMIP6', 'BCC-ESM1', 'Omon', 'sos')
	assert fix == [Sos(None), GenericFix(None)]
	def test_sos_fix():
	"""Test fix for ``sos``."""
	assert Sos is OceanFixGrid

[valeriupredoi]

good call, Manu! I shall, imminently 🍺

[valeriupredoi]

plopped tests in b7b3fc8 and b9b286d bud 🍺

[schlunma]

Thanks @ledm @valeriupredoi 🚀

[valeriupredoi]

and danke Manu 🍺