Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog and release date for v2.9.0 release #2123

Merged
merged 3 commits into from Jul 4, 2023

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Jul 3, 2023

Description

Final updates for the release:

  • update the release notes with latest changes
  • update the version number and release date in CITATION.cff

Link to documentation: https://esmvaltool--2123.org.readthedocs.build/projects/ESMValCore/en/2123/changelog.html#v2-9-0


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added the documentation Improvements or additions to documentation label Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #2123 (1311e4c) into main (276c56c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2123   +/-   ##
=======================================
  Coverage   93.09%   93.09%           
=======================================
  Files         237      237           
  Lines       12794    12794           
=======================================
  Hits        11910    11910           
  Misses        884      884           

@bouweandela bouweandela marked this pull request as ready for review July 3, 2023 13:24
@bouweandela bouweandela added this to the v2.9.0 milestone Jul 3, 2023
Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bouweandela! Looks good to me. I see that PR #2119 is missing but maybe that is intended as this was fixed within a release cycle, right? Do you want to add this PR and maybe #2088 for the changes to the Changelog? You could make a "Release section" or make an entry in the "Documentation" section, as you like. Let me know what you think and I'll approve this PR.

@bouweandela
Copy link
Member Author

I see that PR #2119 is missing but maybe that is intended as this was fixed within a release cycle, right?

Yes, the feature was added, but turned out to be too computationally expensive, so then taken out again.

@bouweandela
Copy link
Member Author

Do you want to add this PR and maybe #2088 for the changes to the Changelog?

Done in 1311e4c

Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bouweandela bouweandela merged commit 8e29121 into main Jul 4, 2023
4 checks passed
@bouweandela bouweandela deleted the update-release-notes branch July 4, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants