Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Github Actions] Compress all bash shell setters into one default option per workflow #2126

Merged
merged 9 commits into from Jul 6, 2023

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jul 4, 2023

Description

This specifies the shell definition (bash, in this case) in a defaults section of the GA workflow, and more importantly, does this only once so that everytime a new command is added (via run key), one doesn't have to keep adding the bash definition above it; this makes the workflow a lot more readable; originally suggested by @bouweandela 🍺

Closes #2031


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #2126 (c7be416) into main (9d6b963) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2126   +/-   ##
=======================================
  Coverage   93.09%   93.09%           
=======================================
  Files         237      237           
  Lines       12794    12794           
=======================================
  Hits        11910    11910           
  Misses        884      884           

@valeriupredoi valeriupredoi marked this pull request as ready for review July 5, 2023 14:01
@valeriupredoi
Copy link
Contributor Author

dis ready now @bouweandela

@valeriupredoi valeriupredoi added this to the v2.10.0 milestone Jul 5, 2023
Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better than before!

@valeriupredoi
Copy link
Contributor Author

many thanks for proposing and reviewing this, @bouweandela 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Github Actions] Compress all bash shell setters into one default option per workflow
2 participants