New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax concatenation checks for --check_level=relax
and --check_level=ignore
#2144
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2144 +/- ##
==========================================
+ Coverage 93.19% 93.26% +0.07%
==========================================
Files 238 238
Lines 12826 12833 +7
==========================================
+ Hits 11953 11969 +16
+ Misses 873 864 -9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks very much @sloosvel - I am a bit confused by this PR but let me have a look at the entire code (in a branch checkout) first, then I'll post me comments πΊ
aye, took a look at the entire |
This is recorded in our provenance here: ESMValCore/esmvalcore/_provenance.py Lines 205 to 211 in ac31d53
The attribute is removed from the cubes because it becomes invalid when we process the data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revising my stale review, cheers, Saskia! πΊ
Description
This PR allows to relax the concatenation checks for
--check_level=relaxed
and--check_level=ignore
. Additionally, the concatenation is performed at once with all cubes, instead of in a two-by-two way. The overlaps in the time coordinate are checked before performing the concatenation, but they consider the same cases as the current implementation.I only tested the concatenation of many files, but I don't know at the top of my head any data with the overlaps that are being considered. So I have not tested with any real dataset. The old tests seem to past though.
Closes (kind of) #2073
Link to documentation: https://esmvaltool--2144.org.readthedocs.build/projects/ESMValCore/en/2144/
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the π Technical or π§ͺ Scientific review.
- [ ] π Any changed dependencies have been added or removed correctlyTo help with the number pull requests: