Update code coverage orbs #2206
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2206 +/- ##
=======================================
Coverage 93.31% 93.31%
=======================================
Files 238 238
Lines 13028 13028
=======================================
Hits 12157 12157
Misses 871 871 |
| @@ -124,6 +124,9 @@ jobs: | |||
| - /root/.cache/pip | |||
| - .mypy_cache | |||
| - .pytest_cache | |||
| - run: | |||
| name: Install gpg (required by codecov orb) | |||
| command: apt update && apt install -y gpg | |||
| - codecov/upload: | |||
| when: always | |||
| file: 'test-reports/coverage.xml' | |||
There was a problem hiding this comment.
what's the report.xml created above used for then?
There was a problem hiding this comment.
It's used to generate the test summary page: https://app.circleci.com/pipelines/github/ESMValGroup/ESMValCore/9756/workflows/2169fe35-d00d-448d-826f-eeaa47109d51/jobs/42339/tests
That looks quite boring for this pr, but if there are some failing tests it gives you a nice quick overview without having to scroll through lots of terminal output.
There was a problem hiding this comment.
There was a problem hiding this comment.
aha! Nice one then, thanks
|
not really liking this new stuff though - it says there are 11 scripts with some indirect chamges to coverage but when I try clicking on one it tells me some error occured (that might be if Codecov server is down) - but those scripts used to be listed in the table in the codecov comment on the PR page - will those be gone now and only visible at the Codecov page? See this for one of those scripts I emntion |
|
It looks like the issue solved itself when the coverage for the latest commit got uploaded. |
still getting the error, but it may be that my Firefox is that old that it's not even called Firefox, and some fansy new Javascript is not found |
The table is only shown when there are files with changed coverage in the PR, that's why you don't see it here. |
I suspected that but I was a bit taken aback by those "files with indirect changes" links I saw earlier - at any rate, am merging this, we spent too much time discussing it already 😁 |
Description
Update the CircleCI orbs for reporting code coverage to a more recent version.
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: