Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cordex wrf381p: fix tas,tasmax,tasmin height #2333

Merged
merged 11 commits into from Apr 2, 2024
Merged

Conversation

mwjury
Copy link
Contributor

@mwjury mwjury commented Feb 12, 2024

Height2m is missing in tas, tasmax, tasmin of the following WRF381P EURO-CORDEX runs:

datasets_rcp45: &datasets_tas_rcp45
  - {institute: IPSL, start_year: 1951, driver: IPSL-IPSL-CM5A-MR, ensemble: r1i1p1, dataset: WRF381P, rcm_version: v1}
datasets_rcp85: &datasets_tas_rcp85
  - {institute: IPSL, start_year: 1951, driver: CNRM-CERFACS-CNRM-CM5, ensemble: r1i1p1, dataset: WRF381P, rcm_version: v2}
  - {institute: IPSL, start_year: 1951, driver: ICHEC-EC-EARTH, ensemble: r12i1p1, dataset: WRF381P, rcm_version: v1}
  - {institute: IPSL, start_year: 1951, driver: IPSL-IPSL-CM5A-MR, ensemble: r1i1p1, dataset: WRF381P, rcm_version: v1}
  - {institute: IPSL, start_year: 1951, driver: MOHC-HadGEM2-ES, end_year: 2099, ensemble: r1i1p1, dataset: WRF381P, rcm_version: v1}
  - {institute: IPSL, start_year: 1951, driver: NCC-NorESM1-M, ensemble: r1i1p1, dataset: WRF381P, rcm_version: v1}

Here's the fix.

@mwjury mwjury added the fix for dataset Related to dataset-specific fix files label Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.10%. Comparing base (46207f8) to head (2089021).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2333      +/-   ##
==========================================
+ Coverage   94.07%   94.10%   +0.02%     
==========================================
  Files         241      246       +5     
  Lines       13422    13477      +55     
==========================================
+ Hits        12627    12682      +55     
  Misses        795      795              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sloosvel sloosvel self-requested a review February 26, 2024 09:33
Copy link
Contributor

@sloosvel sloosvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mwjury! I just added some tests for the changes.

@sloosvel sloosvel added this to the v2.11.0 milestone Feb 26, 2024
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both!

@schlunma schlunma merged commit 3a0b49f into main Apr 2, 2024
6 checks passed
@schlunma schlunma deleted the cdx_wrf381p_tas_fix branch April 2, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix for dataset Related to dataset-specific fix files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants