New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cordex wrf381p: fix tas,tasmax,tasmin height #2333
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2333 +/- ##
==========================================
+ Coverage 94.07% 94.10% +0.02%
==========================================
Files 241 246 +5
Lines 13422 13477 +55
==========================================
+ Hits 12627 12682 +55
Misses 795 795 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mwjury! I just added some tests for the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks both!
Height2m is missing in tas, tasmax, tasmin of the following WRF381P EURO-CORDEX runs:
Here's the fix.