Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cat experiments first, then do the time based cat #2343

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

dhohn
Copy link
Contributor

@dhohn dhohn commented Feb 23, 2024

Description

Solves a bug where concatenation of multiple experiments consisting of datasets with multiple files leads wrong results, where timeranges are mixed randomly from the experiments.
Closes #2342


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.


To help with the number pull requests:

@dhohn dhohn added bug Something isn't working preprocessor Related to the preprocessor labels Feb 23, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 94.04%. Comparing base (9728667) to head (2eed6d1).

Files Patch % Lines
esmvalcore/preprocessor/_io.py 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2343      +/-   ##
==========================================
- Coverage   94.07%   94.04%   -0.03%     
==========================================
  Files         241      241              
  Lines       13414    13424      +10     
==========================================
+ Hits        12619    12625       +6     
- Misses        795      799       +4     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@dhohn dhohn added the help wanted Extra attention is needed label Mar 12, 2024
@dhohn
Copy link
Contributor Author

dhohn commented Mar 12, 2024

I need help with adding tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed preprocessor Related to the preprocessor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

concatenate experiments handles time ordering incorrectly
1 participant