Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement lazy area weights #2354

Merged
merged 6 commits into from Apr 23, 2024
Merged

Implement lazy area weights #2354

merged 6 commits into from Apr 23, 2024

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Feb 28, 2024

Description

This is a simple workaround for lazy area weights until SciTools/iris#5658 is available.

Related to #674


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.


To help with the number pull requests:

@schlunma schlunma added the dask related to improvements using Dask label Feb 28, 2024
@schlunma schlunma added this to the v2.11.0 milestone Feb 28, 2024
@schlunma schlunma self-assigned this Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 94.30%. Comparing base (bbd307d) to head (e645a62).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2354   +/-   ##
=======================================
  Coverage   94.29%   94.30%           
=======================================
  Files         246      246           
  Lines       13540    13549    +9     
=======================================
+ Hits        12768    12777    +9     
  Misses        772      772           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

esmvalcore/preprocessor/_area.py Outdated Show resolved Hide resolved
tests/unit/preprocessor/_area/test_area.py Show resolved Hide resolved
@valeriupredoi
Copy link
Contributor

do we still need this in light of the new iris 3.9.0? If so, just say "duck" and I'll merge it πŸ¦†

@schlunma
Copy link
Contributor Author

πŸ¦†

@schlunma
Copy link
Contributor Author

(the new feature is unfortunately not included in iris 3.9)

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a πŸ¦† 's been asked for!

@valeriupredoi valeriupredoi added the iris Related to the Iris package label Apr 23, 2024
@valeriupredoi valeriupredoi merged commit 1e49077 into main Apr 23, 2024
6 checks passed
@valeriupredoi valeriupredoi deleted the lazy_area_weights branch April 23, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dask related to improvements using Dask iris Related to the Iris package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants