Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not expand wildcards for datasets of derived variables where not all input variables are available #2374

Merged
merged 9 commits into from Apr 3, 2024

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Mar 18, 2024

Description

Do not expand wildcards for datasets of derived variables where not all input variables are available. Currently, this will lead to unexpected missing data errors.

Closes #2373


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added this to the v2.11.0 milestone Mar 18, 2024
@schlunma schlunma self-assigned this Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.12%. Comparing base (3a0b49f) to head (6b349b4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2374      +/-   ##
==========================================
+ Coverage   94.10%   94.12%   +0.02%     
==========================================
  Files         246      246              
  Lines       13477    13490      +13     
==========================================
+ Hits        12682    12697      +15     
+ Misses        795      793       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlunma schlunma marked this pull request as ready for review March 19, 2024 12:05
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, cheers, Manu! But as far as I can see, we're avoiding the problem, not fixing it - yet, it's prob not worth going any deeper anyway 🍺

esmvalcore/_recipe/recipe.py Show resolved Hide resolved
esmvalcore/_recipe/to_datasets.py Show resolved Hide resolved
@valeriupredoi valeriupredoi added the preprocessor Related to the preprocessor label Apr 3, 2024
@valeriupredoi valeriupredoi merged commit e955995 into main Apr 3, 2024
5 of 6 checks passed
@valeriupredoi valeriupredoi deleted the fix_wildcards_for_derived_vars branch April 3, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preprocessor Related to the preprocessor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset wildcards may lead to "missing data" errors for derived variables
2 participants