Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix positive attributes in custom CMOR variables #2380

Merged
merged 4 commits into from Apr 3, 2024

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Mar 25, 2024

Description

This PR fixes positive attributes in custom CMOR variables:

  • For ISCCP cloud are fractions, remove it (it does not make sense to have it here)
  • For the cloud radiative effects (CREs), change it from up to down
  • For TOA Net downward Shortwave Radiation, change it from up to down

This PR also adds missing tests for these derived variables to improve our overall test coverage.


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the cmor Related to the CMOR standard label Mar 25, 2024
@schlunma schlunma added this to the v2.11.0 milestone Mar 25, 2024
@schlunma schlunma self-assigned this Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.25%. Comparing base (3a0b49f) to head (e3a33e7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2380      +/-   ##
==========================================
+ Coverage   94.10%   94.25%   +0.15%     
==========================================
  Files         246      246              
  Lines       13477    13483       +6     
==========================================
+ Hits        12682    12708      +26     
+ Misses        795      775      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlunma schlunma marked this pull request as ready for review March 25, 2024 15:07
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers, Manu! I think you've fixed a bunch of historical bugs I put in many years ago too, if I'm not mistaken 🍺

@bouweandela bouweandela merged commit c8555d4 into main Apr 3, 2024
6 checks passed
@bouweandela bouweandela deleted the fix_positive_attributes branch April 3, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmor Related to the CMOR standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants