Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignored iris warnings about global attributes #2400

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Apr 30, 2024

Description

One more new iris warning to ignore.


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the iris Related to the Iris package label Apr 30, 2024
@schlunma schlunma added this to the v2.11.0 milestone Apr 30, 2024
@schlunma schlunma self-assigned this Apr 30, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.38%. Comparing base (89891ef) to head (243a377).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2400   +/-   ##
=======================================
  Coverage   94.38%   94.38%           
=======================================
  Files         246      246           
  Lines       13737    13739    +2     
=======================================
+ Hits        12965    12967    +2     
  Misses        772      772           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers, Manu 🍻

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even better!

@valeriupredoi valeriupredoi merged commit 7488131 into main Apr 30, 2024
6 checks passed
@valeriupredoi valeriupredoi deleted the remove_more_iris_warnings branch April 30, 2024 15:43
@chrisbillowsMO chrisbillowsMO added the enhancement New feature or request label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request iris Related to the Iris package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants