Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on-the-fly cmoriser for ACCESS native data #2430
base: main
Are you sure you want to change the base?
on-the-fly cmoriser for ACCESS native data #2430
Changes from all commits
b774a36
5acf65c
e7277a0
a0a05bc
a32a48f
efcea11
9c0c9b8
f98406d
2b5f8d5
8043643
a86e1d9
c8bc262
f389559
7815a07
6db0088
4018368
0e864b6
200e2d6
803c544
fbfefdc
88047fc
0cd3498
7cd6cf8
7c91b6c
b446f6f
9a0104f
64054ba
b8c6057
869c481
6885d9a
8cc0f3b
c803837
d2d1da3
013d5f0
b116bfc
c371ba0
84fe2ed
6d80f5f
a566cfd
b666121
f7fb9d7
97acf57
645a203
5f587df
f10b23c
fb3ef3f
fdaf89d
857b9d1
1753b8d
b0e1400
7a06b34
7f2ffeb
24ef703
c5c7393
4569cf5
cadd99e
42ec653
7422346
41c6530
c92373d
fe5e4d6
fecb98b
8f744ff
1456249
bd3769e
e160394
573b4f1
f7081ba
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check notice on line 39 in esmvalcore/cmor/_fixes/access/access_esm.py
Codacy Production / Codacy Static Code Analysis
esmvalcore/cmor/_fixes/access/access_esm.py#L39
Check warning on line 39 in esmvalcore/cmor/_fixes/access/access_esm.py
Codacy Production / Codacy Static Code Analysis
esmvalcore/cmor/_fixes/access/access_esm.py#L39
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend using a more readable format here, e.g.
fld_s02i207 - fld_s02i201 + fld_s03i332 - fld_s02i205
. Instead of usingeval
(which leaves a lot of room for user mistakes and potential security issues), you could just write a regular expression to parse the string to get out the variables and operators, which you then apply.