New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug that made preprocessor with fx files fail in rare cases #670
Conversation
Circle CI fails because the following test: ESMValCore/tests/integration/cmor/test_table.py Lines 292 to 301 in cac2d43
This fails because All other tables entries are fine though (e.g. |
The frequency for custom variables was set to None at read time. I changed it to be set to the empty string so it is consistent with all the others |
I successfully tested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattiarighi Could you please run a final test and merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cheers @schlunma 🍺
yamllint
to check that your YAML files do not contain mistakesIf you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes #448.