Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash for FGOALS-g2 variables without longitude coordinate #729

Merged
merged 1 commit into from Oct 1, 2020
Merged

Fix crash for FGOALS-g2 variables without longitude coordinate #729

merged 1 commit into from Oct 1, 2020

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Jul 22, 2020 •
edited

Closes #728

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Add unit tests
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.

@bouweandela bouweandela added bug Something isn't working fix for dataset Related to dataset-specific fix files labels Jul 22, 2020
@bouweandela bouweandela mentioned this pull request Sep 24, 2020
Closed
@bouweandela bouweandela requested review from valeriupredoi and removed request for mattiarighi September 28, 2020 15:07
@bouweandela bouweandela added this to the v2.1.0 milestone Sep 30, 2020
@bouweandela
Copy link
Member Author

@valeriupredoi Would you have time to review this pull request, so it can still be included in v2.1?

jvegreg
jvegreg reviewed Oct 1, 2020
View reviewed changes
Copy link
Contributor

@jvegreg jvegreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

It looks strange to ignore the requested coordinates if they are not there, but as we are checking everything after this is applied is actually fine.

valeriupredoi
valeriupredoi approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean! Nice catch!

@valeriupredoi valeriupredoi merged commit a961853 into master Oct 1, 2020
@valeriupredoi valeriupredoi deleted the fgoals-g2-fix branch October 1, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvegreg jvegreg jvegreg left review comments

@valeriupredoi valeriupredoi valeriupredoi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working fix for dataset Related to dataset-specific fix files
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

variables from FGOALS-g2 without longitude coordinate cannot be read
3 participants
@bouweandela @jvegreg @valeriupredoi