Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logic for calling the diagnostic script to avoid problems with scripts where the executable bit is accidentally set #877

Merged
merged 5 commits into from Nov 25, 2020

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Nov 24, 2020

By always using the extension as a guideline on what interpreter to use before checking the executable bit, we avoid problems for users who set the wrong executable bit or are unable to control this (e.g. NTFS filesystems on Windows)

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Add unit tests (already existed)
  • Documentation added
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.

Closes #828

By always using the extension as a guideline on what interpreter to use before checking the executable bit, we avoid problems for users who set the wrong executable bit or are unable to control this (e.g. NTFS filesystems on Windows)
@bouweandela bouweandela added this to ESMValCore - needs review in November 2020 Nov 24, 2020
Copy link
Contributor

@stefsmeets stefsmeets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works with my use-case!

esmvalcore/_task.py Outdated Show resolved Hide resolved
esmvalcore/_task.py Show resolved Hide resolved
@stefsmeets stefsmeets moved this from ESMValCore - needs review to Done in November 2020 Nov 24, 2020
@bouweandela bouweandela moved this from Done to Needs Merge in November 2020 Nov 24, 2020
@bouweandela bouweandela merged commit 8aa05c2 into master Nov 25, 2020
November 2020 automation moved this from Needs Merge to Done Nov 25, 2020
@bouweandela bouweandela deleted the script-call-logic branch November 25, 2020 08:36
@jvegreg jvegreg added the bug Something isn't working label Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

OSError: [Errno 8] Exec format error: '.../custom_recipe.py'
3 participants