Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the list of broken recipes for v2.11.0 #3662

Closed
mo-gill opened this issue Jun 19, 2024 · 3 comments · Fixed by #3706
Closed

Update the list of broken recipes for v2.11.0 #3662

mo-gill opened this issue Jun 19, 2024 · 3 comments · Fixed by #3706
Assignees
Milestone

Comments

@mo-gill
Copy link
Contributor

mo-gill commented Jun 19, 2024

We are at the "Update the list of broken recipes" step in the ESMValTool release process for v2.11.0, see #3565 (comment).

Using information from the broken recipe list and #3484: Recipes with issues discovered during the 2.10.0 release test runs and noting:

recipe_check_obs.yml

recipe_julia.yml

  • recipe_julia.yml produces unusable plot #2595 is still open, and the v2.11.0rc1 plot still contains no data. This recipe has now been broken since at least v2.5.0, see the v2.5.0 plot. The broken recipe policy states:

    If a recipe continues to be broken for three releases of the ESMValTool (about one year) and no recipe maintainer could be found during this time, the affected recipe and diagnostics will be retired. This means the recipe and diagnostic code are removed from the ESMValTool main branch by the release manager and thus will not be included in future releases.

    Should this recipe now be retired?

recipe_seaice_drift.yml

recipe_psyplot.yml

... the broken recipe list should be updated to:

Broken recipe Affected diagnostics Broken since release Problem GitHub issue
recipe_climwip_brunner2019_med.yml All (preprocessor issue) v2.11.0 Failed to run preprocessor function 'fix_metadata' on the data: Unable to convert units #3694
recipe_collins13ipcc.yml All (preprocessor issue) v2.10.0 Failed to run preprocessor function 'save' on the data: HDF error #3702
recipe_easy_ipcc.yml All v2.11.0 Failed to download data #3703
recipe_ipccwg1ar6ch3_atmosphere.yml All (preprocessor issue) v2.10.0 Failed to run preprocessor function 'save' on the data: HDF error #3702
recipe_ocean_amoc.yml diag_timeseries_amoc, diag_transects v2.11.0 CESM1 CMIP5 Omon data no longer available #3693
recipe_preprocessor_derive_test.yml All (preprocessor issue) v2.11.0 Failed to run preprocessor function 'save' on the data: HDF error #3702
recipe_tebaldi21esd.yml All (preprocessor issue) v2.10.0 Failed to run preprocessor function 'save' on the data: HDF error #3702
recipe_russell18jgr.yml Figure_4 v2.11.0 CESM1 CMIP5 Omon data no longer available #3693
recipe_wenzel14jgr.yml diag_tsline_Fig2d v2.11.0 CESM1 CMIP5 Omon data no longer available #3693
@ehogan
Copy link
Contributor

ehogan commented Jun 27, 2024

recipe_seaice_drift.yml

@flicj191, @rbeucher, given you both were involved in #3243, would it be possible for you to comment on the above, please? 😊

@flicj191
Copy link
Contributor

recipe_seaice_drift.yml

@flicj191, @rbeucher, given you both were involved in #3243, would it be possible for you to comment on the above, please? 😊

It was fixed so it runs, maybe need an author or scientific review for the different plots.
As some python packages were updated since it was authored and involved projection transformations so calculations could be somehow truncated from previous I'm guessing. So I think its ok to remove from broken recipes.

@bouweandela
Copy link
Member

recipe_julia.yml: Should this recipe now be retired?

Let's keep it, it is the example recipe for Julia diagnostics. It does need an update though. It looks like the Julia software stack is finally starting to become useful for climate data: https://github.com/mauro3/Julia-intro-for-geoscience-EGU2024/blob/main/notebooks/geo-ecosystem.ipynb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants