Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding recipe and diagnostics for Gier et al 2020 #1914

Merged
merged 50 commits into from
Feb 11, 2021
Merged

Adding recipe and diagnostics for Gier et al 2020 #1914

merged 50 commits into from
Feb 11, 2021

Conversation

bettina-gier
Copy link
Contributor

@bettina-gier bettina-gier commented Nov 25, 2020

Draft pull request for Code to recreate Gier et al 2020, Biogeosciences with diagnostics for all figures. Analysis for XCO2 (Column-averaged CO2).

Description


Before you get started

Checklist

It is the responsibility of the author to make sure the PR is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic:


To help with the number pull requests:


Draft pull request as some things still need to be done:

  • Clean up recipe - done
  • Add provenance to station_comparison.ncl -> done
  • Change units to be taken from file, not variable info -> done
  • Add cmorizer scripts for new data (ESRL but different format) -> done and merged
  • Add core branch for fixes and XCO2 derivation script -> done and merged
  • Add documentation - done
  • Updated checklist to the new one ;)

Closes issue #1915

@bettina-gier bettina-gier marked this pull request as ready for review February 10, 2021 14:56
@bettina-gier
Copy link
Contributor Author

Checked that it works with the new core release and the iris 3 in the esmvaltool! Ready for review @schlunma
ACCESS-ESM1-5 model commented out, as it requires regridding in the xco2 derivation script. Still left in as comment to show it was in the paper. As this reproduces a paper which went through full peer review, a detailed scientific examination is not necessary.

Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good (one small comment on the changes in auxiliary.ncl), documentation looks good (some minor comments). Would it be possible to replace the figures in the documentation with lower-resolution versions? Some of them are pretty large (1.2 MB), and I don't think this high resolution is necessary here 😉

Running the recipe now for the scientific review!

doc/sphinx/source/recipes/recipe_gier20bg.rst Outdated Show resolved Hide resolved
doc/sphinx/source/recipes/recipe_gier20bg.rst Show resolved Hide resolved
esmvaltool/diag_scripts/shared/plot/styles/cmip5.style Outdated Show resolved Hide resolved
esmvaltool/interface_scripts/auxiliary.ncl Show resolved Hide resolved
@schlunma
Copy link
Contributor

Plots, nc files and provenance look good, everything is similar to the paper! 👍

@schlunma schlunma merged commit 0b0e7a7 into master Feb 11, 2021
@schlunma schlunma deleted the gier20_bg branch February 11, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementing Gier et al 2020
5 participants