-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding recipe and diagnostics for Gier et al 2020 #1914
Conversation
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
Checked that it works with the new core release and the iris 3 in the esmvaltool! Ready for review @schlunma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good (one small comment on the changes in auxiliary.ncl
), documentation looks good (some minor comments). Would it be possible to replace the figures in the documentation with lower-resolution versions? Some of them are pretty large (1.2 MB), and I don't think this high resolution is necessary here 😉
Running the recipe now for the scientific review!
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
Plots, nc files and provenance look good, everything is similar to the paper! 👍 |
Draft pull request for Code to recreate Gier et al 2020, Biogeosciences with diagnostics for all figures. Analysis for XCO2 (Column-averaged CO2).
Description
Before you get started
Checklist
It is the responsibility of the author to make sure the PR is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
pre-commit
oryamllint
checksNew or updated recipe/diagnostic:
@esmvalbot
or some other machine without modificationTo help with the number pull requests:
Draft pull request as some things still need to be done:
Closes issue #1915