Add fix for iris longitude bug to ClimWIP

[lukasbrunner]

Description

Implement a fix for a iris longitude problem (ESMValGroup/ESMValCore#800) in the ClimWIP mapplot diagnostic

• Closes Fix ClimWIP mapplot longitude values #2106

---

Before you get started

• ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🛠 This pull request has a descriptive title
• 🛠 Code is written according to the code quality guidelines
• 🛠 Documentation is available
• 🛠 Tests run successfully
• 🛠 The list of authors is up to date
• 🛠 Any changed dependencies have been added or removed correctly
• 🛠 All checks below this pull request were successful

New or updated recipe/diagnostic

• 🧪 Recipe runs successfully
• 🧪 Recipe is well documented
• 🧪 Figure(s) and data look as expected from literature
• 🛠 Provenance information has been added

New or updated data reformatting script

• 🛠 Documentation is available
• 🛠 The dataset has been added to the CMOR check recipe
• 🧪 Numbers and units of the data look physically meaningful

---

To help with the number of pull requests:

• 🙏 We kindly ask you to review two other open pull requests in this repository

[Peter9192]

Looks good! Can you have a look at the flake8 errors?

[Peter9192]

Looks good to me. @ruthlorenz as a formality could you do a very quick scientific check?

[ruthlorenz]

What do you need me to check?
I run a quick test using a region crossing the 0 meridian, result attached. But might just be a plotting issue.
temperature_change_weighted_map.pdf

[ruthlorenz]

no actually the preprocessed files already look like this....
All I changed is the start_longitude in recipe_climwip_basic_check.yml to be -10 (and the xticks accordingly)

[Peter9192]

What do you need me to check?
...
no actually the preprocessed files already look like this....
All I changed is the start_longitude in recipe_climwip_basic_check.yml to be -10 (and the xticks accordingly)

Good catch! I think it's exactly that: you try to use the updated recipe and verify that it provides the results you expected. Sometimes it might also make sense to look at the equations, but in this case that's not really relevant I think.

[lukasbrunner]

Good catch @ruthlorenz I had indeed used the wrong default for the antimeridian in the file I pushed. Now it should run. I've also updated the recipe_climwip_test_basic as I guess it is here to test all these cases. So now the are starts at -10 by default to cover that case.

(for regions crossing the -180/180 there is still a problem I would leave it for now and try fix that should we ever need it)

[ruthlorenz]

works like a charm now :-)

[lukasbrunner]

Can you merge this @Peter9192? Just to clean up :)

[Peter9192]

I'm not authorized to merge, sorry. You can tag ESMValGroup/esmvaltool-coreteam instead, if you're happy with the docs. I think you might need a blank line below the code block header.

[lukasbrunner]

I'm not authorized to merge, sorry. You can tag ESMValGroup/esmvaltool-coreteam instead, if you're happy with the docs. I think you might need a blank line below the code block header.

Will do! Sorry the comment actually belonged to another PR (too many browser windows)

[lukasbrunner]

ping @nielsdrost @valeriupredoi :)