Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when using log-scale y-axis for ocean transects. #2862

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

TomasTorsvik
Copy link
Contributor

@TomasTorsvik TomasTorsvik commented Oct 17, 2022

Using plt.axes().set_ylogscale('log') creates a new axes on top of the original figure. Replace with plt.gca().set_yscale('log') to adjust the existing figure axes to log scale.

Description


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

Using `plt.axes().set_ylogscale('log')` creates a new axes on top of the
original figure. Replace with `plt.gca().set_yscale('log')` to adjust
the existing figure axes to log scale.
@valeriupredoi
Copy link
Contributor

great, many thanks @TomasTorsvik - could I please ask you to clean up the PR description by ticking relevant boxes, and removing/striking-through the ones that don't apply here? @ledm it would be great if you could review this so we can include it in the 2.7.0 release - I'll approve it from a technical review point as soon as the PR description is cleaned up 👍 🍺

@valeriupredoi valeriupredoi added this to the v2.7.0 milestone Oct 18, 2022
@TomasTorsvik
Copy link
Contributor Author

I have updated the checklist and removed the items that doesn't apply to this PR. I'm not sure if I should tick the boxes myself or if this is supposed to be done by the PR reviewer. I have ticked them myself for now.

@valeriupredoi
Copy link
Contributor

cheers muchly @TomasTorsvik - all great from my side, if @ledm can review it sci-wise then we'll get it done asap 🍺

@ledm
Copy link
Contributor

ledm commented Oct 19, 2022

Great, looks fine to me!

@valeriupredoi
Copy link
Contributor

@esmvalbot please run recipe_ocean_example.yml

@esmvalbot
Copy link

esmvalbot bot commented Oct 19, 2022

Since @valeriupredoi asked, ESMValBot will run recipe recipe_ocean_example.yml as soon as possible, output will be generated here

@valeriupredoi
Copy link
Contributor

ah I forgot the bot is slightly impaired today with Levante offline, gonna run all next week for the release anyway, this is getting merged. Cheers, gents - @TomasTorsvik @ledm 🍺

@valeriupredoi valeriupredoi merged commit 85bea1b into main Oct 19, 2022
@valeriupredoi valeriupredoi deleted the fix_ocean_transect_plot branch October 19, 2022 14:29
@esmvalbot
Copy link

esmvalbot bot commented Oct 19, 2022

ESMValBot is sorry to report it failed to run recipe recipe_ocean_example.yml: exit is 1, output has been generated here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty/blank ocean transect plots when using log vertical axes
3 participants