Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated monitoring diagnostics with netCDF output and additional logging #3029

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Jan 25, 2023

Description

This PR adds netCDF output to the diagnostic monitor/multi_datasets.py and also shows the statistics printed in the figures in the log file.

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@schlunma
Copy link
Contributor Author

@esmvalbot please run monitor/recipe_monitor_with_refs.yml

@esmvalbot
Copy link

esmvalbot bot commented Jan 25, 2023

Since @schlunma asked, ESMValBot will run recipe monitor/recipe_monitor_with_refs.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Jan 25, 2023

ESMValBot is sorry to report it failed to run recipe monitor/recipe_monitor_with_refs.yml: exit is 1, output has been generated here

@valeriupredoi
Copy link
Contributor

ESMValBot is sorry to report it failed to run recipe monitor/recipe_monitor_with_refs.yml: exit is 1, output has been generated here

missing data for native6 - don't think that ever existed on the bot's space, @remi-kazeroni correct me if I'm wrong, bud

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good (although I'd use a different key than n for a string hehe) and Codacy warnings are benign - technical approval here, man 👍

Copy link
Contributor

@Paulinebonnet111 Paulinebonnet111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diagnostic script works as expected ! Thanks !

@schlunma schlunma merged commit 50884e6 into main Jan 26, 2023
@schlunma schlunma deleted the monitor_log_stats branch January 26, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants