Realize data for scalar cube in recipe_carvalhais14nat to avert issue from dask latest (2023.6.0)
#3265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-kazeroni
changed the title
recipe_carvalhais14nat to avert issue from dask latest (2023.6.0)
|
Thanks for the detailed investigation, @valeriupredoi and for the review, @bouweandela. We'll see in the upcoming recipe testing if there is still an issue with this recipe. Merging now |
bouweandela
pushed a commit
that referenced
this pull request
Jul 4, 2023
…ue from dask latest (2023.6.0) (#3265)
jvegreg
pushed a commit
that referenced
this pull request
Jan 14, 2024
…ue from dask latest (2023.6.0) (#3265)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of Release 2.9.0 #3239
using the core_data() method introduces a strange issue from Dask (only 2023.3.0 or older behaves well); I unfortunately have not managed to reproduce the issue in a test case/minimal test example so instead am just realizing the data - there is no problem about it since that's a scalar cube with one single data point. Not nice but meh. The fix leads to the recipe still failing but this is explained in #3239 (comment)
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic