Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata: pr does not follow CF-convention #3

Closed
bouweandela opened this issue Oct 20, 2017 · 2 comments
Closed

Metadata: pr does not follow CF-convention #3

bouweandela opened this issue Oct 20, 2017 · 2 comments

Comments

@bouweandela
Copy link
Member

bouweandela commented Oct 20, 2017 •
edited

According to the CF-convention, standard_name should be precipitation_flux instead of precipitation for variable 'pr'.
@bouweandela
Copy link
Member Author

Maybe it would be better to get the information in the Metadata class from an external source, e.g. autogenerate from the cf-convention xml document, or import from another Python package, instead of hardcoding.

bjoernbroetz added a commit that referenced this issue Oct 20, 2017
@bjoernbroetz
Merge pull request #4 from ESMValGroup/dev_metadata
a7973a3 
Fix #3, follow CF-convention
@bjoernbroetz
Copy link
Collaborator

Right! This cf-convention is also subject to change (new variables can enter). This should be external. There will be a new issue for that.

@bjoernbroetz bjoernbroetz mentioned this issue Oct 20, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bouweandela @bjoernbroetz