Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add '-e' pip dependencies to merge test #119

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Add '-e' pip dependencies to merge test #119

merged 1 commit into from
Oct 13, 2020

Conversation

ap--
Copy link
Contributor

@ap-- ap-- commented Oct 13, 2020

This PR is making the tests more explicit and tests that (issue #118) '-e' editable pip dependencies don't get merged.

Note: This was already fixed in #114 and already included in v2.1.1

@ap--
Add '-e' pip dependencies to merge test
15d71d2 
Explictly test issue ESSS#118 '-e' editable pip dependencies.

Note: this was already fixed in ESSS#114 and included in v2.1.1
nicoddemus
nicoddemus approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicoddemus nicoddemus merged commit 43af2fe into ESSS:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ap-- @nicoddemus