Add error propagation to eager tasks #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarPersson
force-pushed
the
eager-task-propagation
branch
from
eb619d1
to
2183fce
Compare
OskarPersson
changed the title
Codecov Report
@@ Coverage Diff @@
## master #989 +/- ##
==========================================
- Coverage 62.81% 62.79% -0.03%
==========================================
Files 212 212
Lines 20345 20334 -11
Branches 2453 2454 +1
==========================================
- Hits 12780 12768 -12
- Misses 7123 7124 +1
Partials 442 442
Continue to review full report at Codecov.
|
pettanj
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the customized version of DBTask.apply() and instead uses DBTask.success and DBTask.failure to update the database when eager tasks succeeds or fails.
By using the built-in DBTask.apply() we get proper task propagation that is better suited for testing