Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the storage of keyframes from a std::vector to std::unordered_map #2

Open
puzzlepaint opened this issue Jun 18, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@puzzlepaint
Copy link
Collaborator

Currently, the keyframes are stored in a std::vector, and removing keyframes leaves nullptr entries in that vector. This is likely not to be handled correctly in all parts of the codebase, leading to crashes. It would most likely be preferable to store the keyframes in an unordered_map instead (mapping keyframe_id -> keyframe_pointer) and delete removed keyframes from it entirely.

@puzzlepaint
Copy link
Collaborator Author

Hi, this comment is unrelated to the original topic of this issue. I thus moved it to a new issue: #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant