etl/type_traits.h: Add support for type_identity #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
Did you add a unit test? |
|
Sorry, I overlooked that part :/ I'm away from my computer right now, but would the following be enough if I added it later? Given this function: template <typename T>
T add(T first, typename etl::type_identity<T>::type second) {
return first + second;
}The result of |
|
That looks OK. |
…entity_test_add(1.5f, 2) == 3.5f)
|
Did I do this right? 😅 |
jwellbelove
reviewed
Jun 10, 2024
Use CHECK_CLOSE instead of CHECK for equality
|
Well, I changed the CHECK into a CHECK_CLOSE. |
jwellbelove
changed the base branch from
master
to
pull-request/#905-Add-support-for-type_identity
jwellbelove
merged commit 6ced063
into
ETLCPP:pull-request/#905-Add-support-for-type_identity
63 checks passed
jwellbelove
pushed a commit
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.